Takashi Yano via Cygwin-apps writes:
> Anyway I'll revise the cygport file. Any suggenstions
> will be appreciated.

I've looked at the cygport in more detail, comments below.


Indentation is inconsistent.  I personally prefer not to use tabs and
reduce indentation to four.

The bootstrapping should be enabled by (the presence of) variables in
the build environment without the need to edit the cygport file.  Use
"defined ENV_VAR" where possible and do not check for string content.
Any dependencies between these variables should probably be enforced
intead of just warned about.

The packaging does not succeed if the build runs in a case-insensitive
filesystem due to parallel usr/share/doc/{LLVM,llvm} directories.

It is not acceptable for the cygport to download files from the net
and/or install any pre-requisites outside the build directory.  In other
words, remove that curl invocation and use SRC_URI for that and cut out
the pip3, that's what BUILD_REQUIRES are for (and yes, you will have to
provide those packages if they don't already exist).

Use the read-only convenience variables for referencing the package
variables:
 NAME                 -> PN
 VERSION              -> PV
 RELEASE              -> PR 
 NAME-VERSION         -> P
 NAME-VERSION-RELEASE -> PVR


Bootstrapping llvm worked, but the tests can not be run due to missing
googletest.


Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

SD adaptation for Waldorf microQ V2.22R2:
http://Synth.Stromeko.net/Downloads.html#WaldorfSDada

Reply via email to