On Thu, 24 Apr 2025 19:02:29 -0700 (PDT) Jeremy Drake via Cygwin-apps <cygwin-apps@cygwin.com> wrote:
> This package uses python3 at build time. I inherit-ed python3, would > I be better off putting it in BUILD_REQUIRES instead? If it merely needs to execute some python scripts (seems to be the case here), rather than build something like python modules, I don't think python3 cygclass is needed, but in that case you should add it as build dep. I suggest to put patches from Gentoo in a subdir "gentoo", and similarly for any existing outside patch, so that in the future we know where this is from (lots of mystery patches in repos), and so one can potentially look again if something changed where it comes from. Or maybe it could be tied in neatly as a submodule without pulling the whole portage tree structure? Don't know if that could be done, would love to see it in action! To my knowledge, BUILD_REQUIRES is everything involved in generating the package (application/library/doc/test). You can clarify things with some comments, like BUILD_REQUIRES+=" ..." #doc BUILD_REQUIRES+=" ..." #test But... who needs to know about test dependencies to build the package? The package build service needs it for sure. If can't do tests/don't pass tests -> no deploy option. -- Philippe Baril Lecavalier
