On Thu, 24 Apr 2025, Mark Geisert via Cygwin-apps wrote: > Hi Jeremy, > > On 4/24/2025 11:57 AM, Jeremy Drake via Cygwin-apps wrote: > > On Wed, 23 Apr 2025, Mark Geisert via Cygwin wrote: > > > > > A new version 1.4.17-4 of the cygutils packages with a corrected > > > 'cygstart' is now making its way to the mirrors. > > > > Can I ask why patches are made in the packaging rather than applied to > > the cygwin-apps/cygutils git repository, given that this package is > > "local" to Cygwin and therefore has no other "upstream"? How would you > > decide to make a 1.4.17-4 rather than a 1.4.18-1? > > A fair question. > > I think cygutils might have been the first package I ITA'd years ago. I > wasn't yet up to speed on the whole package management framework. I'm > (somewhat) better with the more recent adoptions I've made. As time permits > all the packages I manage will be done identically and involve the cygwin-apps > git repository, the CI process, etc. > > I personally would probably go to 1.4.18-1 when some major packaging change > was made. I went from 1.4.16 to 1.4.17 when I took over from Chuck Wilson. > > As for every maintainer here (and elsewhere), lack of time is an issue.
OK. It made trying to update the package in MSYS2 more of a pain (https://github.com/msys2/MSYS2-packages/pull/5353). I went with making your package revision into a 4th part of the version, so that the MSYS2 package could maintain its own "pkgrel". You may be interested in the patch I just made to allow the package to build against older runtimes (by skipping lssparse if SEEK_HOLE is not defined). --- a/Makefile.am 2025-04-24 13:03:35.750405000 -0700 +++ b/Makefile.am 2025-04-24 13:24:52.995906000 -0700 @@ -32,9 +32,13 @@ cygwin_specific_progs = src/cygdrop/cygdrop endif +if WITH_LSSPARSE +lssparse_progs = src/lssparse/lssparse +endif + bin_PROGRAMS = $(windows_progs) src/conv/conv \ src/dump/dump $(ipc_progs) \ - src/lssparse/lssparse \ + $(lssparse_progs) \ $(cygwin_specific_progs) bin_SCRIPTS = $(ipc_scripts) --- a/configure.ac +++ b/configure.ac @@ -82,6 +82,7 @@ case "$host" in *cygwin* ) AC_MSG_ERROR([At least cygwin-1.7 is required]) ;; esac],dnl [[#include <sys/cygwin.h>]]) +AC_CHECK_DECL([SEEK_HOLE],[],[],[[#include <unistd.h>]]) dnl Set Conditionals for Makefile.am AM_CONDITIONAL(WITH_WINDOWS_PROGRAMS, test "$ac_cv_func_OpenClipboard" = yes) @@ -91,6 +92,7 @@ case "$host" in *cygwin* ) host_is_cygwin=yes ;; esac AM_CONDITIONAL(WITH_CYGWIN_SPECIFIC_PROGRAMS, test "$host_is_cygwin" = yes) +AM_CONDITIONAL(WITH_LSSPARSE, test "$ac_cv_have_decl_SEEK_HOLE" = yes) AC_CONFIG_FILES([Makefile po/Makefile.in src/cygicons/cygicons.rc])
