I just looked at your sgrep package:
Package: sgrep 1.99.1-1 [2003-09-15] Description: Search indexed text regions like SGML, XML and HTML files Proposer: Jari Aalto Proposal: http://sources.redhat.com/ml/cygwin-apps/2003-09/msg00166.html http://tierra.dyndns.org:81/cygwin/sgrep/sgrep-1.92.1-1.tar.bz2 http://tierra.dyndns.org:81/cygwin/sgrep/sgrep-1.92.1-1-src.tar.bz2 http://tierra.dyndns.org:81/cygwin/sgrep/setup.hint Aye votes: Lapo Luchini (cygwin-apps-thread.11774) [1/3] Dr. Volker Zell (cygwin-apps-thread.12054) [2/3] Status: Package available. HOLD-UPS: Not enough votes (need 1 more). No "good to go" review.
Problems ========
1) Upon extracting the archive I noticed that the build script is called "cygbuild-1.99.1-1.sh", rather than "sgrep-1.99.1-1.sh". This will cause problems since the source is extracted to /usr/src, not /usr/src/rdesktop, so any other source package with version 1.99.1-1 would get its similarly-named build script clobbered.
2) Upon performing an "./cygbuild-1.99.1-1.sh spkg", the -src package gets a copy of the build script called "cygbuild-1.99.1-1-1.99.1-1.sh"... its keeps appending the version to the build script. Not good.
[Note: These two problems seem to be due to the cygbuild project... you are the maintainer, so I guess you will fix them :)]
3) The build script complains during the build process:
./cygbuild-1.92.1-1.sh: line 440: [: -eq: unary operator expected
See the attached log from the "all" command for more info and context.
4) You don't list the cygbuild package in the README as a build requirement, when it does seem to be required to do an 'spkg' build.
5) Again, the build occurs in the same directory as the source. Yuk.
Poke the list when the issues have been fixed or otherwise addressed (like telling me to suck an egg, or something similar :).
Harold
-- cygbuild.sh 2003-11-09 1.219 http://cygbuild.sourceforge.net/ -- Wait, examining environment and preparing variables ./cygbuild-1.92.1-1.sh: line 440: [: -eq: unary operator expected -- Extracting /home/harold/ports/sgrep/sgrep-1.92.1.tar.gz -- Hm, archive did not extract into directory sgrep-1.92.1 ... -- Renaming unpack dir sgrep-1.92a/ to sgrep-1.92.1 -- Making Cygwin directories under /home/harold/ports/sgrep/sgrep-1.92.1 -- Patching --forward --strip=0 --fuzz=3 --quiet < /home/harold/ports/sgrep/sgrep-1.92.1-1.patch in /home/harold/ports/sgrep -- If patch fails, you may need rm -rf /home/harold/ports/sgrep/sgrep-1.92.1 -- Running ./configure with Cygwin specific options creating cache ./config.cache checking for a BSD compatible install... /usr/bin/install -c checking whether build environment is sane... yes checking whether make sets ${MAKE}... yes checking for working aclocal... found checking for working autoconf... found checking for working automake... found checking for working autoheader... found checking for gcc... gcc checking whether the C compiler (gcc ) works... yes checking whether the C compiler (gcc ) is a cross-compiler... no checking whether we are using GNU C... yes checking whether gcc accepts -g... yes checking for gcc option to accept ANSI C... none needed checking how to run the C preprocessor... gcc -E checking whether make sets ${MAKE}... (cached) yes checking for Cygwin32 environment... yes checking for ANSI C header files... yes checking for sys/wait.h that is POSIX.1 compatible... yes checking for fcntl.h... yes checking for limits.h... yes checking for sys/time.h... yes checking for unistd.h... yes checking for sys/times.h... yes checking for sys/mman.h... yes checking for working const... yes checking for pid_t... yes checking for size_t... yes checking for vprintf... yes checking for mmap... yes checking for dup... yes checking for dup2... yes checking for pipe... yes checking for fileno... yes checking for select... yes checking for strerror... yes checking for strtol... yes checking for times... yes checking for vsnprintf... yes Using preprocessor 'm4 -s' Enabling assertions. Enabling memory leak and allocation debugging. updating cache ./config.cache creating ./config.status creating Makefile creating config.h -- Building with standard make(1) gcc -DHAVE_CONFIG_H -I. -I/home/harold/ports/sgrep/sgrep-1.92.1 -I. -DDATADIR="\"/usr/share\"" -c main.c gcc -DHAVE_CONFIG_H -I. -I/home/harold/ports/sgrep/sgrep-1.92.1 -I. -DDATADIR="\"/usr/share\"" -c preproc.c gcc -DHAVE_CONFIG_H -I. -I/home/harold/ports/sgrep/sgrep-1.92.1 -I. -DDATADIR="\"/usr/share\"" -c common.c gcc -DHAVE_CONFIG_H -I. -I/home/harold/ports/sgrep/sgrep-1.92.1 -I. -DDATADIR="\"/usr/share\"" -c parser.c gcc -DHAVE_CONFIG_H -I. -I/home/harold/ports/sgrep/sgrep-1.92.1 -I. -DDATADIR="\"/usr/share\"" -c optimize.c gcc -DHAVE_CONFIG_H -I. -I/home/harold/ports/sgrep/sgrep-1.92.1 -I. -DDATADIR="\"/usr/share\"" -c pmatch.c gcc -DHAVE_CONFIG_H -I. -I/home/harold/ports/sgrep/sgrep-1.92.1 -I. -DDATADIR="\"/usr/share\"" -c sgml.c gcc -DHAVE_CONFIG_H -I. -I/home/harold/ports/sgrep/sgrep-1.92.1 -I. -DDATADIR="\"/usr/share\"" -c eval.c gcc -DHAVE_CONFIG_H -I. -I/home/harold/ports/sgrep/sgrep-1.92.1 -I. -DDATADIR="\"/usr/share\"" -c output.c gcc -DHAVE_CONFIG_H -I. -I/home/harold/ports/sgrep/sgrep-1.92.1 -I. -DDATADIR="\"/usr/share\"" -c index.c gcc -DHAVE_CONFIG_H -I. -I/home/harold/ports/sgrep/sgrep-1.92.1 -I. -DDATADIR="\"/usr/share\"" -c sysdeps.c gcc -o sgrep main.o preproc.o common.o parser.o optimize.o pmatch.o sgml.o eval.o output.o index.o sysdeps.o -- Installing docs to /home/harold/ports/sgrep/sgrep-1.92.1/.inst/usr/share/doc/sgrep-1.92.1 -- Installing [Cygwin] docs /home/harold/ports/sgrep/sgrep-1.92.1/.inst/usr/share/doc/Cygwin -- Running install to /home/harold/ports/sgrep/sgrep-1.92.1/.inst -- Running 'make install' -- See also: find .inst/ -print /bin/sh /home/harold/ports/sgrep/sgrep-1.92.1/mkinstalldirs /home/harold/ports/sgrep/sgrep-1.92.1/.inst/usr/bin mkdir /home/harold/ports/sgrep/sgrep-1.92.1/.inst/usr/bin /usr/bin/install -c sgrep /home/harold/ports/sgrep/sgrep-1.92.1/.inst/usr/bin/sgrep make install-man1 make[1]: Entering directory `/home/harold/ports/sgrep/sgrep-1.92.1' /bin/sh /home/harold/ports/sgrep/sgrep-1.92.1/mkinstalldirs /home/harold/ports/sgrep/sgrep-1.92.1/.inst/usr/share/man/man1 mkdir /home/harold/ports/sgrep/sgrep-1.92.1/.inst/usr/share/man mkdir /home/harold/ports/sgrep/sgrep-1.92.1/.inst/usr/share/man/man1 /usr/bin/install -c -m 644 /home/harold/ports/sgrep/sgrep-1.92.1/sgrep.1 /home/harold/ports/sgrep/sgrep-1.92.1/.inst/usr/share/man/man1/sgrep.1 make[1]: Leaving directory `/home/harold/ports/sgrep/sgrep-1.92.1' /bin/sh /home/harold/ports/sgrep/sgrep-1.92.1/mkinstalldirs /home/harold/ports/sgrep/sgrep-1.92.1/.inst/usr/share /usr/bin/install -c -m 644 /home/harold/ports/sgrep/sgrep-1.92.1/sample.sgreprc /home/harold/ports/sgrep/sgrep-1.92.1/.inst/usr/share/sample.sgreprc -- Running post-install /home/harold/ports/sgrep/sgrep-1.92.1/CYGWIN-PATCHES/install-after.sh .inst -- Stripping *.exe and *.dll -- Making package [binary] /home/harold/ports/sgrep/sgrep-1.92.1-1.tar.bz2
