[Review - Not yet] rdesktop

Harold L Hunt II Wed, 26 Nov 2003 13:35:36 -0800

Jari,

I just looked at your rdesktop package:

Daniel Reed wrote:

Package: rdesktop 1.3.0-1  [2003-11-08]
Description: client for Windows terminal server. Remote desktop display
   Proposer: Jari Aalto
   Proposal: mailto:[EMAIL PROTECTED]
             http://tierra.dyndns.org:81/cygwin/rdesktop/rdesktop-1.3.0-1.tar.bz2
             http://tierra.dyndns.org:81/cygwin/rdesktop/rdesktop-1.3.0-1-src.tar.bz2
             [no hint]
  Aye votes: Harold L Hunt II (cygwin-apps-thread.12044) [1/3]
             Abe Backus (cygwin-apps-thread.12051) [2/3]
     Status: Package available.
   HOLD-UPS: Not enough votes (need 1 more). No "good to go" review.


Problems
========

1) Upon extracting the archive I noticed that the build script is called "cygbuild-1.3.0-1.sh", rather than "rdesktop-1.3.0-1.sh". This will cause problems since the source is extracted to /usr/src, not /usr/src/rdesktop, so any other source package with version 1.3.0-1 would get its similarly-named build script clobbered.

2) Upon performing an "./cygbuild-1.3.0-1.sh all", the -src package gets a copy of the build script called "cygbuild-1.3.0-1-1.3.0-1.sh"... its keeps appending the version to the build script. Not good.

3) There are two instances of "permission denied" being reported by find during the build process. See the attached log from doing an "all". The error is below:

find: /home/harold/x-devel/4.3/ports/rdesktop/rdesktop-1.3.0/.inst/usr/share/doc/rdesktop-1.3.0: Permission denied

4) The script builds in the same directory as the source code. I don't like that. I have not yet (I hope) released a package that does this and I don't give good reviews to packages that do it. If the package fails to build out of the source directory, than you can either use lndir or the similar but more portable suggestion that Chuck Wilson had a few weeks/months ago (don't remember what it was called). If they cygbuild script doesn't yet support this, then it isn't ready for prime-time and you should hack up one of the scripts from another source package to do the job in the mean time.

5) Your rdesktop.README lists the following requirements:

Runtime requirements:
  cygwin-1.3.22 or newer

Build requirements:
  cygwin-1.3.22 or newer

Yet, a "cygcheck rdesktop.exe" gives:

$ cygcheck rdesktop.exe
Found: .\rdesktop.exe
rdesktop.exe
  C:\cygwin\usr\X11R6\bin\cygX11-6.dll
    C:\cygwin\bin\cygcygipc-2.dll
      C:\cygwin\bin\cygwin1.dll
        C:\WINDOWS\System32\KERNEL32.dll
          C:\WINDOWS\System32\ntdll.dll
  C:\cygwin\bin\cygcrypto-0.9.7.dll

So, I can see that you need at least the following (and possibly more):

Runtime requirements:
  cygwin-1.5.3 or newer
  cygipc
  openssl
  XFree86-bin

Build requirements:
  cygwin-1.5.3 or newer
  cygipc
  openssl-devel
  XFree86-prog

6) Similarly to #5, your setup.hint only lists:

requires: cygwin

That should have the same requirement as the runtime requirements in #5, and possibly more.

Poke the list when these issues have been fixed or otherwise addressed and I will review the package again.

Harold

-- cygbuild.sh 2003-10-05 1.217 http://cygbuild.sourceforge.net/
-- Wait, examining environment and preparing variables
./cygbuild-1.3.0-1.sh: line 438: [: -eq: unary operator expected
-- Extracting /home/harold/x-devel/4.3/ports/rdesktop/rdesktop-1.3.0.tar.gz
--    Hm, archive did not extract into directory rdesktop-1.3.0 ...
--    Renaming unpack dir rdesktop/ to rdesktop-1.3.0
-- Making Cygwin directories under 
/home/harold/x-devel/4.3/ports/rdesktop/rdesktop-1.3.0
-- Patching  --forward  --strip=0  --fuzz=3  --quiet < 
/home/harold/x-devel/4.3/ports/rdesktop/rdesktop-1.3.0-1.patch in 
/home/harold/x-devel/4.3/ports/rdesktop
--    If patch fails, you may need rm -rf 
/home/harold/x-devel/4.3/ports/rdesktop/rdesktop-1.3.0
--   External 
/home/harold/x-devel/4.3/ports/rdesktop/rdesktop-1.3.0/CYGWIN-PATCHES/configure.sh
rdesktop build configuration script


X Window System:
  includes  /usr/X11R6/include
  libraries /usr/X11R6/lib

OpenSSL:
  includes  /usr/include
  libraries /usr/lib

Sound support enabled: Open Sound System

configure complete - now run make
-- Building with standard make(1)
gcc -DKEYMAP_PATH=\"usr/share/rdesktop/keymaps\" -Wall -O2 -I/usr/X11R6/include 
-DWITH_OPENSSL -DWITH_RDPSND -o rdesktop.o -c rdesktop.c
gcc -DKEYMAP_PATH=\"usr/share/rdesktop/keymaps\" -Wall -O2 -I/usr/X11R6/include 
-DWITH_OPENSSL -DWITH_RDPSND -o xwin.o -c xwin.c
xwin.c: In function `ui_select':
xwin.c:1244: warning: implicit declaration of function `select'
gcc -DKEYMAP_PATH=\"usr/share/rdesktop/keymaps\" -Wall -O2 -I/usr/X11R6/include 
-DWITH_OPENSSL -DWITH_RDPSND -o xkeymap.o -c xkeymap.c
gcc -DKEYMAP_PATH=\"usr/share/rdesktop/keymaps\" -Wall -O2 -I/usr/X11R6/include 
-DWITH_OPENSSL -DWITH_RDPSND -o ewmhints.o -c ewmhints.c
gcc -DKEYMAP_PATH=\"usr/share/rdesktop/keymaps\" -Wall -O2 -I/usr/X11R6/include 
-DWITH_OPENSSL -DWITH_RDPSND -o xclip.o -c xclip.c
gcc -DKEYMAP_PATH=\"usr/share/rdesktop/keymaps\" -Wall -O2 -I/usr/X11R6/include 
-DWITH_OPENSSL -DWITH_RDPSND -o cliprdr.o -c cliprdr.c
gcc -DKEYMAP_PATH=\"usr/share/rdesktop/keymaps\" -Wall -O2 -I/usr/X11R6/include 
-DWITH_OPENSSL -DWITH_RDPSND -o rdpsnd.o -c rdpsnd.c
gcc -DKEYMAP_PATH=\"usr/share/rdesktop/keymaps\" -Wall -O2 -I/usr/X11R6/include 
-DWITH_OPENSSL -DWITH_RDPSND -o rdpsnd_oss.o -c rdpsnd_oss.c
gcc -DKEYMAP_PATH=\"usr/share/rdesktop/keymaps\" -Wall -O2 -I/usr/X11R6/include 
-DWITH_OPENSSL -DWITH_RDPSND -o tcp.o -c tcp.c
gcc -DKEYMAP_PATH=\"usr/share/rdesktop/keymaps\" -Wall -O2 -I/usr/X11R6/include 
-DWITH_OPENSSL -DWITH_RDPSND -o iso.o -c iso.c
gcc -DKEYMAP_PATH=\"usr/share/rdesktop/keymaps\" -Wall -O2 -I/usr/X11R6/include 
-DWITH_OPENSSL -DWITH_RDPSND -o mcs.o -c mcs.c
gcc -DKEYMAP_PATH=\"usr/share/rdesktop/keymaps\" -Wall -O2 -I/usr/X11R6/include 
-DWITH_OPENSSL -DWITH_RDPSND -o secure.o -c secure.c
gcc -DKEYMAP_PATH=\"usr/share/rdesktop/keymaps\" -Wall -O2 -I/usr/X11R6/include 
-DWITH_OPENSSL -DWITH_RDPSND -o licence.o -c licence.c
gcc -DKEYMAP_PATH=\"usr/share/rdesktop/keymaps\" -Wall -O2 -I/usr/X11R6/include 
-DWITH_OPENSSL -DWITH_RDPSND -o rdp.o -c rdp.c
gcc -DKEYMAP_PATH=\"usr/share/rdesktop/keymaps\" -Wall -O2 -I/usr/X11R6/include 
-DWITH_OPENSSL -DWITH_RDPSND -o orders.o -c orders.c
gcc -DKEYMAP_PATH=\"usr/share/rdesktop/keymaps\" -Wall -O2 -I/usr/X11R6/include 
-DWITH_OPENSSL -DWITH_RDPSND -o bitmap.o -c bitmap.c
gcc -DKEYMAP_PATH=\"usr/share/rdesktop/keymaps\" -Wall -O2 -I/usr/X11R6/include 
-DWITH_OPENSSL -DWITH_RDPSND -o cache.o -c cache.c
cache.c: In function `cache_get_text':
cache.c:122: warning: comparison is always true due to limited range of data type
cache.c: In function `cache_put_text':
cache.c:139: warning: comparison is always true due to limited range of data type
gcc -DKEYMAP_PATH=\"usr/share/rdesktop/keymaps\" -Wall -O2 -I/usr/X11R6/include 
-DWITH_OPENSSL -DWITH_RDPSND -o rdp5.o -c rdp5.c
gcc -DKEYMAP_PATH=\"usr/share/rdesktop/keymaps\" -Wall -O2 -I/usr/X11R6/include 
-DWITH_OPENSSL -DWITH_RDPSND -o channels.o -c channels.c
gcc -DKEYMAP_PATH=\"usr/share/rdesktop/keymaps\" -Wall -O2 -I/usr/X11R6/include 
-DWITH_OPENSSL -DWITH_RDPSND -o rdpdr.o -c rdpdr.c
gcc -DKEYMAP_PATH=\"usr/share/rdesktop/keymaps\" -Wall -O2 -I/usr/X11R6/include 
-DWITH_OPENSSL -DWITH_RDPSND -o serial.o -c serial.c
gcc -DKEYMAP_PATH=\"usr/share/rdesktop/keymaps\" -Wall -O2 -I/usr/X11R6/include 
-DWITH_OPENSSL -DWITH_RDPSND -o printer.o -c printer.c
gcc -DKEYMAP_PATH=\"usr/share/rdesktop/keymaps\" -Wall -O2 -I/usr/X11R6/include 
-DWITH_OPENSSL -DWITH_RDPSND -o rdesktop rdesktop.o xwin.o xkeymap.o ewmhints.o 
xclip.o cliprdr.o rdpsnd.o rdpsnd_oss.o tcp.o iso.o mcs.o secure.o licence.o rdp.o 
orders.o bitmap.o cache.o rdp5.o channels.o rdpdr.o serial.o printer.o  
-L/usr/X11R6/lib -lcrypto -lX11
--   Installing docs to 
/home/harold/x-devel/4.3/ports/rdesktop/rdesktop-1.3.0/.inst/usr/share/doc/rdesktop-1.3.0
find: 
/home/harold/x-devel/4.3/ports/rdesktop/rdesktop-1.3.0/.inst/usr/share/doc/rdesktop-1.3.0:
 Permission denied
--   Installing [Cygwin] docs 
/home/harold/x-devel/4.3/ports/rdesktop/rdesktop-1.3.0/.inst/usr/share/doc/Cygwin
--   Installing with external 
/home/harold/x-devel/4.3/ports/rdesktop/rdesktop-1.3.0/CYGWIN-PATCHES/install.sh .inst
--    See also: find .inst/ -print
mkdir -p /home/harold/x-devel/4.3/ports/rdesktop/rdesktop-1.3.0/.inst/usr/bin
install rdesktop /home/harold/x-devel/4.3/ports/rdesktop/rdesktop-1.3.0/.inst/usr/bin
strip /home/harold/x-devel/4.3/ports/rdesktop/rdesktop-1.3.0/.inst/usr/bin/rdesktop*
chmod 755 
/home/harold/x-devel/4.3/ports/rdesktop/rdesktop-1.3.0/.inst/usr/bin/rdesktop*
mkdir -p 
/home/harold/x-devel/4.3/ports/rdesktop/rdesktop-1.3.0/.inst/usr/share/rdesktop/keymaps
cp keymaps/?? keymaps/??-?? 
/home/harold/x-devel/4.3/ports/rdesktop/rdesktop-1.3.0/.inst/usr/share/rdesktop/keymaps
cp keymaps/common 
/home/harold/x-devel/4.3/ports/rdesktop/rdesktop-1.3.0/.inst/usr/share/rdesktop/keymaps
cp keymaps/modifiers 
/home/harold/x-devel/4.3/ports/rdesktop/rdesktop-1.3.0/.inst/usr/share/rdesktop/keymaps
chmod 644 
/home/harold/x-devel/4.3/ports/rdesktop/rdesktop-1.3.0/.inst/usr/share/rdesktop/keymaps/*
mkdir -p /home/harold/x-devel/4.3/ports/rdesktop/rdesktop-1.3.0/.inst/usr/share/man1
cp doc/rdesktop.1 
/home/harold/x-devel/4.3/ports/rdesktop/rdesktop-1.3.0/.inst/usr/share/man1
chmod 644 
/home/harold/x-devel/4.3/ports/rdesktop/rdesktop-1.3.0/.inst/usr/share/man1/rdesktop.1
find: 
/home/harold/x-devel/4.3/ports/rdesktop/rdesktop-1.3.0/.inst/usr/share/doc/rdesktop-1.3.0:
 Permission denied
-- Stripping *.exe and *.dll
-- Making package [binary] 
/home/harold/x-devel/4.3/ports/rdesktop/rdesktop-1.3.0-1.tar.bz2
-- Making [patch] 
/home/harold/x-devel/4.3/ports/rdesktop/rdesktop-1.3.0/.sinst/rdesktop-1.3.0-1.patch
-- Making package [source] 
/home/harold/x-devel/4.3/ports/rdesktop/rdesktop-1.3.0-1-src.tar.bz2

[Review - Not yet] rdesktop

Reply via email to