On 12/05/2011 12:10, Ben Lippmeier wrote:

On 12/05/2011, at 8:22 PM, Simon Peyton-Jones wrote:

GHC hackers,

Finally!  I have committed the new representation for coercions!
This is a pretty big patch touching a lot of files. If you are
working on anything that intersects the type checker, it'll affect
you.


Looks good!

A minor point is that I just tried to validate this and I made the
mistake of using my git gui to pull the changes from the GHC repo
without running ./sync-all pull first.

Perhaps "sh validate" should also run "./sync-all pull" and
"./sync-all get" first? Can anyone think of a reason not to? This has
also bitten me in the past.


I use a wrapper script that runs './sync-all pull --ff-only' before running validate (and afterwards it sends an SMS to my phone with the results).

I suppose sync-all pull would be a reasonable default, but it *must* be --ff-only, I don't want validate generating any commits.

Cheers,
        Simon

_______________________________________________
Cvs-ghc mailing list
Cvs-ghc@haskell.org
http://www.haskell.org/mailman/listinfo/cvs-ghc

Reply via email to