Hello Jeremy,
On 05.06.20 16:28, Jeremy Jackson wrote:
> So far, after 3 people reviewing, there have been 2 identified users of
> the .config and "revision" files embedded in CFBS, which may be affected
> by adding the prefix fallback/normal/<custom>
>
> It was suggested to reach out via the mailing list, to see if anyone
> else would be affected by this change.
I think we should keep the original copies for two reasons:
1. Backwards compatibility.
2. Not everything in CBFS is fallback/normal specific.
For instance the bootblock is never overwritten with CONFIG_UPDATE_IMAGE
set. So it seems reasonable to keep the `config` and `revision` files
for the original build.
The logic could be as follows:
if !CONFIG_UPDATE_IMAGE
store config
store revision
endif
# and always
store $prefix/config
store $prefix/revision
Nico
_______________________________________________
coreboot mailing list -- [email protected]
To unsubscribe send an email to [email protected]
