On 3/23/10 12:14 PM, Joseph Smith wrote:
> Good question. It does two checks. First to see if HPET is enabled, and
> second to verify the hpet base address bits match the input value (hpet).
> If either one of these are false it leaves with a err message, makes sure
> HPET is disabled and continues on. Maybe printk_err() is a bit harsh here
> because it doesn't actually die() if there is an error, but I wanted to
> make sure it is _KNOWN_ in the bootlog if there was an issue enabling HPET.
> Does that make sense?
>
I think it does, since we're enabling an undocumented feature here.
printk_err is fine.. die() is more along the line of printk_emerg
--
coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: [email protected] • http://www.coresystems.de/
Registergericht: Amtsgericht Freiburg • HRB 7656
Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866
--
coreboot mailing list: [email protected]
http://www.coreboot.org/mailman/listinfo/coreboot
