On Wed, 2 Jul 2025 15:14:47 GMT, Lance Andersen <lan...@openjdk.org> wrote:

>> simon has updated the pull request incrementally with one additional commit 
>> since the last revision:
>> 
>>   8360122: revert reformatting method signatures
>
> src/java.sql/share/classes/java/sql/Connection.java line 1175:
> 
>> 1173:      */
>> 1174:     void setClientInfo(String name, String value)
>> 1175:         throws SQLClientInfoException;
> 
> The throws clause could be moved up

Fixed

> src/java.sql/share/classes/java/sql/Connection.java line 1208:
> 
>> 1206:      */
>> 1207:     void setClientInfo(Properties properties)
>> 1208:         throws SQLClientInfoException;
> 
> The throws clause could be moved up

Fixed

> src/java.sql/share/classes/java/sql/Connection.java line 1232:
> 
>> 1230:      * @see java.sql.DatabaseMetaData#getClientInfoProperties
>> 1231:      */
>> 1232:     String getClientInfo(String name)
> 
> the throws clause could be moved up

Fixed

> src/java.sql/share/classes/java/sql/Connection.java line 1251:
> 
>> 1249:      */
>> 1250:     Properties getClientInfo()
>> 1251:         throws SQLException;
> 
> The throws clause could be moved up

Fixed

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25925#discussion_r2181380031
PR Review Comment: https://git.openjdk.org/jdk/pull/25925#discussion_r2181379915
PR Review Comment: https://git.openjdk.org/jdk/pull/25925#discussion_r2181379825
PR Review Comment: https://git.openjdk.org/jdk/pull/25925#discussion_r2181379234

Reply via email to