On Tue, 22 Apr 2025 16:39:21 GMT, Artur Barashev <abaras...@openjdk.org> wrote:
>> Daniel Fuchs has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 506 commits: >> >> - merge latest changes from master branch >> - http3: update H3InsertionsLimitTest to start after receival of client >> settings >> - merge latest changes from master branch >> - quic: separate out the idle termination timer and the STREAM_DATA_BLOCKED >> timer >> - quic: simplify idle timeout management >> - http3: rely on the sole isOpen() method instead of isOpen() and isClosed() >> - quic: do not let h3 idle (in pool) timeout to influence the quic >> transport idle timeout >> - merge latest changes from master branch >> - http3: improve H3ConnectionPoolTest.java >> - Fix snippet >> - ... and 496 more: https://git.openjdk.org/jdk/compare/8d33ea73...d4984d5e > > src/java.base/share/classes/sun/security/ssl/X509TrustManagerImpl.java line > 265: > >> 263: // engine, localSupportedSignAlgs, false); >> 264: // } else { >> 265: // constraints = SSLAlgorithmConstraints.forEngine(engine, >> false); > > We need these to check peer's certificate against constraints specified in > `java.security` config file. It looks like `SSLAlgorithmConstraints` class > would need a new `forQuicTLSEngine` method. Hello Daniel @dfuchs, this can be marked as resolved since the changes proposed by Artur have been implemented in this PR. There's now a `SSLAlgorithmConstraints.forQUIC()` method. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24751#discussion_r2166016865