On Mon, 16 Jun 2025 07:09:39 GMT, Kim Barrett <kbarr...@openjdk.org> wrote:

>> Please review this change which adds a native method providing the
>> implementation of Reference::get.  Referece::get is an intrinsic candidate, 
>> so
>> this native method implementation is only used when the intrinsic is not.
>> 
>> Currently there is intrinsic support by the interpreter, C1, C2, and graal,
>> which are always used.  With this change we can later remove all the
>> per-platform interpreter intrinsic implementations, and might also remove the
>> C1 intrinsic implementation.
>> 
>> Testing:
>> (1) mach5 tier1-6 normal (so using all the existing intrinsics).
>> (2) mach5 tier1-6 with interpreter and C1 Reference::get intrinsics disabled.
>
> Kim Barrett has updated the pull request with a new target base due to a 
> merge or a rebase. The incremental webrev excludes the unrelated changes 
> brought in by the merge/rebase. The pull request contains 17 additional 
> commits since the last revision:
> 
>  - Merge branch 'master' into native-reference-get
>  - add pseudo-native entry for Reference.get0
>  - tidy CallGenerator lookup in Compile ctor
>  - fix comment alignment
>  - Merge branch 'master' into native-reference-get
>  - make private native Reference.get0 the intrinsic
>  - Merge branch 'master' into native-reference-get
>  - Merge branch 'master' into native-reference-get
>  - use new waitForRefProc, some tidying
>  - Merge branch 'master' into native-reference-get
>  - ... and 7 more: https://git.openjdk.org/jdk/compare/3be7ee90...877e64ca

Marked as reviewed by tschatzl (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/24315#pullrequestreview-2937932097

Reply via email to