On Wed, 30 Apr 2025 13:43:28 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> Ioi Lam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Renamed the internal field ReferenceQueue.NULL to NULL_QUEUE to avoid
>> failing hotspot/jtreg/sources/TestNoNULL.java
>
> src/java.base/share/classes/java/lang/ref/Reference.java line 313:
>
>> 311: }
>> 312:
>> 313: private static void runtimeSetup() {
>
> I don't know if you are planning an annotation or something to mark these
> "runtimeSetup" methods but each one will minimally need a comment so that
> it's clear to anyone touching this code that it may be called by the VM when
> loading the AOT cache.
Yes, the plan is to use annotation to mark the `runtimeSetup` and
`assemblySetup` methods.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24757#discussion_r2068947399
