On Wed, 22 May 2024 05:16:42 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
> Can I please get a review of this test-only change for addressing > https://bugs.openjdk.org/browse/JDK-8332490? > > The jmh test opens a `InflaterInputStream`, reads the stream contents, but > then doesn't close the stream. This can lead to resource leak which can then > cause OOM as noted in that JBS issue. > > The commit in this PR closes the `InflaterInputStream` when the reads > complete. > > > make test TEST=micro:org.openjdk.bench.java.util.zip.InflaterInputStreams > > and > > > ./build/macosx-aarch64/images/jdk/bin/java -jar > ./build/macosx-aarch64/images/test/micro/benchmarks.jar > org.openjdk.bench.java.util.zip.InflaterInputStreams.inflaterInputStreamRead > -t max -f 1 -wi 2 -foe true > > pass after this change. This pull request has now been integrated. Changeset: 98f6a808 Author: Jaikiran Pai <j...@openjdk.org> URL: https://git.openjdk.org/jdk/commit/98f6a80852383dcbdad7292b7d269a8547d54d45 Stats: 5 lines in 1 file changed: 3 ins; 0 del; 2 mod 8332490: JMH org.openjdk.bench.java.util.zip.InflaterInputStreams.inflaterInputStreamRead OOM Reviewed-by: aturbanov, redestad ------------- PR: https://git.openjdk.org/jdk/pull/19340
