On Wed, 22 May 2024 07:49:27 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> Can I please get a review of this test-only change for addressing >> https://bugs.openjdk.org/browse/JDK-8332490? >> >> The jmh test opens a `InflaterInputStream`, reads the stream contents, but >> then doesn't close the stream. This can lead to resource leak which can then >> cause OOM as noted in that JBS issue. >> >> The commit in this PR closes the `InflaterInputStream` when the reads >> complete. >> >> >> make test TEST=micro:org.openjdk.bench.java.util.zip.InflaterInputStreams >> >> and >> >> >> ./build/macosx-aarch64/images/jdk/bin/java -jar >> ./build/macosx-aarch64/images/test/micro/benchmarks.jar >> org.openjdk.bench.java.util.zip.InflaterInputStreams.inflaterInputStreamRead >> -t max -f 1 -wi 2 -foe true >> >> pass after this change. > > Jaikiran Pai has updated the pull request incrementally with one additional > commit since the last revision: > > add a comment Sorry, thought I had already approved. Comment is fine. ------------- Marked as reviewed by redestad (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/19340#pullrequestreview-2072382952
