On Wed, 28 Jun 2023 19:35:27 GMT, Naoto Sato <na...@openjdk.org> wrote:
>> Roger Riggs has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Reopen to work on an improved fix >> Add a test for the specific condition being optimized, the test was >> missing in the original. > > test/jdk/java/time/tck/java/time/TCKOffsetDateTime.java line 1384: > >> 1382: assertEquals(b.compareTo(b) == 0, true); >> 1383: assertEquals(a.toInstant().compareTo(b.toInstant()) == 0, >> true); >> 1384: assertEquals(OffsetDateTime.timeLineOrder().compare(a,b) == 0, >> true); > > Could be in a separate test case, as this method tests `compareTo` method? This is one of a sequence of tests of compareTo. The other (previous) tests include verifying the assertion about the result of the `timeLineOrder` comparator with the same data. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/14618#discussion_r1245695820
