On 7/10/25 17:51, Collin Funk wrote:
Hi Karl,
Karl Berry <k...@freefriends.org> writes:
Hi Collin, Dmitry, and all,
The first patch removes a K&R declaration which are removed by C23, and
likely to be removed by compilers in the future. I assume all compilers
support ANSI C declarations nowadays.
...
mips:*:*:UMIPS | mips:*:*:RISCos)
But the question is not what compilers support "nowadays", but what the
compiler on the system in your patch supports. Which is ancient
MIPS. And as far as Wikipedia knows, MIPS/UMIPS and MIPS/RISCos have
been discontinued for a long, long time. I suspect that some versions
of their compiler don't support ANSI C declaration. In any case, I see
no advantage to taking out the K&R declaration.
Ah, right, you are correct. It is 4.3BSD or Unix System V apparently
[1].
Thanks for correcting me, I have gotten used to deleting K&R
declarations out of instinct...
Therefore, ignore the first patch. The second is unrelated though, so
that is fine.
Maybe the first patch should instead be superseded with a new patch that
adds a comment to this effect, lest some future overzealous contributor
make the same mistake?
Maybe something like "This test program is only used on ancient MIPS
systems with K&R compilers."?
-- Jacob
