Hi Collin, Dmitry, and all,
The first patch removes a K&R declaration which are removed by C23, and
likely to be removed by compilers in the future. I assume all compilers
support ANSI C declarations nowadays.
...
mips:*:*:UMIPS | mips:*:*:RISCos)
But the question is not what compilers support "nowadays", but what the
compiler on the system in your patch supports. Which is ancient
MIPS. And as far as Wikipedia knows, MIPS/UMIPS and MIPS/RISCos have
been discontinued for a long, long time. I suspect that some versions
of their compiler don't support ANSI C declaration. In any case, I see
no advantage to taking out the K&R declaration.
It's the same reason why config.* should not be updated to use shell
features that almost(*) every shell "nowadays" supports, like
$(...). The scripts have to run on systems that definitely don't support
that. Maybe in 50 years all those systems will be gone, though I
wouldn't count on it. (Not that it'll matter to me one way or
another. :)
Happy old-time hacking,
Karl
(*) Last I checked, $(...) and other POSIX shell features are not
supported by Solaris 10 /bin/sh, which is still widely, widely, used,
and will continue to be for the foreseeable future.
