On Fri, Dec 24, 2021 at 12:08:14PM -0500, Elad Lahav wrote: > That works too, thanks. > What is the significance of the change to config-sub.data? > > --Elad
testsuite/config-sub.data is a part of the test suite, when adding a new feature to config.sub, it makes sense to add a test for it. > On Fri, 24 Dec 2021 at 11:51, Dmitry V. Levin wrote: > > On Fri, Dec 24, 2021 at 07:49:44AM -0500, Elad Lahav wrote: > > > QNX reports the architecture as aarch64le (on little-endian machines), > > > which matches neither aarch64 nor aarch64_be. > > > I don't know how standardized these architecture names are supposed to > > > be. This may be a trivial change to add or a contentious topic. > > > Hopefully the former. > > > > Wouldn't it be more appropriate to treat aarch64le as an alias to aarch64 > > like in the following patch: > > > > diff --git a/config.sub b/config.sub > > index 38f3d03..e0e1799 100755 > > --- a/config.sub > > +++ b/config.sub > > @@ -1121,7 +1121,7 @@ case $cpu-$vendor in > > xscale-* | xscalee[bl]-*) > > cpu=`echo "$cpu" | sed 's/^xscale/arm/'` > > ;; > > - arm64-*) > > + arm64-* | aarch64le-*) > > cpu=aarch64 > > ;; > > > > diff --git a/testsuite/config-sub.data b/testsuite/config-sub.data > > index d911c5b..44bd2f1 100644 > > --- a/testsuite/config-sub.data > > +++ b/testsuite/config-sub.data > > @@ -26,6 +26,7 @@ aarch64_be-elf > > aarch64_be-unknown-elf > > aarch64_be-linux aarch64_be-unknown-linux-gnu > > aarch64_be-unknown-elf aarch64_be-unknown-elf > > aarch64_be-unknown-linux aarch64_be-unknown-linux-gnu > > +aarch64le-qnx aarch64-unknown-qnx > > abacus abacus-unknown-none > > adobe68k m68010-adobe-scout > > alliant fx80-alliant-none > > > > > > -- > > ldv -- ldv
