[
https://issues.apache.org/jira/browse/HADOOP-12540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14988498#comment-14988498
]
Chris Nauroth commented on HADOOP-12540:
----------------------------------------
I see patch v02 now sets {{leaseID}} to {{null}}, but then there is still an
unguarded {{releaseLease}} in the {{finally}} block. Similar to my last
question, is it legal to pass {{null}} to the {{releaseLease}} call?
Intuitively, I would think not, so I was really looking for this in the
{{finally}} block:
{code}
if (leaseID != null) {
testAccount.releaseLease(leaseID, fileName);
}
{code}
BTW, I noticed you deleted the old v02 patch and uploaded a new one with the
same name. Instead, would you please leave the old files there and use a new
file name with the revision number incremented? We prefer to maintain an
unaltered history of the patch revisions.
Thanks again!
> TestAzureFileSystemInstrumentation#testClientErrorMetrics fails
> intermittently due to assumption that a lease error will be thrown.
> -----------------------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-12540
> URL: https://issues.apache.org/jira/browse/HADOOP-12540
> Project: Hadoop Common
> Issue Type: Bug
> Components: azure, test
> Reporter: Chris Nauroth
> Assignee: Gaurav Kanade
> Attachments: HADOOP-12540.01.patch, HADOOP-12540.02.patch,
> HADOOP-12540.03.patch
>
>
> HADOOP-12508 changed the behavior of an Azure Storage lease violation during
> deletes. It appears that
> {{TestAzureFileSystemInstrumentation#testClientErrorMetrics}} is partly
> dependent on the old behavior for simulating an error to be tracked by the
> metrics system. I am seeing intermittent failures in this test.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
