[
https://issues.apache.org/jira/browse/HADOOP-12540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14988474#comment-14988474
]
Chris Nauroth commented on HADOOP-12540:
----------------------------------------
{code}
String leaseID = "";
{code}
If the attempt to create the file or acquire the lease fails with an exception,
then {{leaseID}} will remain the empty string. Then, in the {{finally}} block,
it would call {{testAccount.releaseLease}} with an empty string. Is that
legal? I was expecting to see {{leaseID}} set to {{null}} before the {{try}}
block, and then the {{finally}} block guards the {{releaseLease}} with a check
for {{null}} before making the call.
I'll be +1 (pending Jenkins) after that's addressed. Thanks!
> TestAzureFileSystemInstrumentation#testClientErrorMetrics fails
> intermittently due to assumption that a lease error will be thrown.
> -----------------------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-12540
> URL: https://issues.apache.org/jira/browse/HADOOP-12540
> Project: Hadoop Common
> Issue Type: Bug
> Components: azure, test
> Reporter: Chris Nauroth
> Assignee: Gaurav Kanade
> Attachments: HADOOP-12540.01.patch, HADOOP-12540.02.patch
>
>
> HADOOP-12508 changed the behavior of an Azure Storage lease violation during
> deletes. It appears that
> {{TestAzureFileSystemInstrumentation#testClientErrorMetrics}} is partly
> dependent on the old behavior for simulating an error to be tracked by the
> metrics system. I am seeing intermittent failures in this test.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
