[ 
https://issues.apache.org/jira/browse/HADOOP-10775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14935603#comment-14935603
 ] 

Steve Loughran commented on HADOOP-10775:
-----------------------------------------

Checkstyle
{code}
./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Shell.java:52:
 First sentence should end with a period.
./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Shell.java:59:
 First sentence should end with a period.
./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Shell.java:64:
 First sentence should end with a period.
./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Shell.java:69:
 First sentence should end with a period.
./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Shell.java:269:
 First sentence should end with a period.
./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Shell.java:377:
 First sentence should end with a period.
./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Shell.java:465:
 First sentence should end with a period.
./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Shell.java:468:
 First sentence should end with a period.
./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Shell.java:471:
 First sentence should end with a period.
./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Shell.java:527:
 First sentence should end with a period.
./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Shell.java:541:
 First sentence should end with a period.
./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Shell.java:566:
 First sentence should end with a period.
./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Shell.java:571:
 First sentence should end with a period.
{code}

And javac, which is from the new  deprecation warnings
{code}
https://builds.apache.org/job/PreCommit-HADOOP-Build/7735/artifact/patchprocess/diffJavacWarnings.txt
{code}

will fix

> Shell operations to fail with meaningful errors on windows if winutils.exe 
> not found
> ------------------------------------------------------------------------------------
>
>                 Key: HADOOP-10775
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10775
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: util
>    Affects Versions: trunk-win, 2.7.1
>         Environment: windows
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>            Priority: Minor
>         Attachments: HADOOP-10775-002.patch, HADOOP-10775-003.patch, 
> HADOOP-10775-004.patch, HADOOP-10775.patch
>
>
> If {{winutils.exe}} can't be found {{HADOOP_HOME}} wrong/unset or other 
> causes, then an error is logged -but when any of the {{Shell}} operations are 
> used, an NPE is raised rather than something meaningful.
> The error message at setup time should be preserved and then raised before 
> any attempt to invoke a winutils-driven process made



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to