[
https://issues.apache.org/jira/browse/HADOOP-10775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14743951#comment-14743951
]
Steve Loughran commented on HADOOP-10775:
-----------------------------------------
Checkstyle
{code}
./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Shell.java:52:
Line is longer than 80 characters (found 98).
./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Shell.java:312:
Line is longer than 80 characters (found 88).
./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Shell.java:352:
Line is longer than 80 characters (found 89).
./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Shell.java:420:
First sentence should end with a period.
./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Shell.java:442:
Line is longer than 80 characters (found 87).
./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Shell.java:449:
First sentence should end with a period.
./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Shell.java:463:
First sentence should end with a period.
./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Shell.java:829:
Line is longer than 80 characters (found 91).
{code}
javac
{code}
> [WARNING]
> /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/NativeLibraryChecker.java:[103,24]
> [deprecation] getWinUtilsPath() in Shell has been deprecated
{code}
that is: the newly deprecated method
> Shell operations to fail with meaningful errors on windows if winutils.exe
> not found
> ------------------------------------------------------------------------------------
>
> Key: HADOOP-10775
> URL: https://issues.apache.org/jira/browse/HADOOP-10775
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Affects Versions: trunk-win, 2.7.1
> Environment: windows
> Reporter: Steve Loughran
> Priority: Minor
> Attachments: HADOOP-10775-002.patch, HADOOP-10775.patch
>
>
> If {{winutils.exe}} can't be found {{HADOOP_HOME}} wrong/unset or other
> causes, then an error is logged -but when any of the {{Shell}} operations are
> used, an NPE is raised rather than something meaningful.
> The error message at setup time should be preserved and then raised before
> any attempt to invoke a winutils-driven process made
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
