[
https://issues.apache.org/jira/browse/HADOOP-11323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14219803#comment-14219803
]
Andrew Wang commented on HADOOP-11323:
--------------------------------------
+1 LGTM. I'll commit this shortly.
> WritableComparator: default implementation of compare keeps reference to byte
> array
> -----------------------------------------------------------------------------------
>
> Key: HADOOP-11323
> URL: https://issues.apache.org/jira/browse/HADOOP-11323
> Project: Hadoop Common
> Issue Type: Improvement
> Components: performance
> Affects Versions: 2.5.0
> Reporter: Wilfred Spiegelenburg
> Assignee: Wilfred Spiegelenburg
> Attachments: HADOOP-11323.patch
>
>
> When the default compare is used on a WritableComparator a reference to the
> second passed in byte array is kept in the buffer. Since WritableComparator
> keeps a reference to the buffer the byte will never be garbage collected.
> This can lead to a higher heap use than needed.
> The buffer should drop the reference to the byte array passed in. We can null
> out the byte array reference since the buffer is a private variable for the
> class.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
