[
https://issues.apache.org/jira/browse/HADOOP-11323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14219275#comment-14219275
]
Hadoop QA commented on HADOOP-11323:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12682613/HADOOP-11323.patch
against trunk revision a9a0cc3.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5107//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5107//console
This message is automatically generated.
> WritableComparator: default implementation of compare keeps reference to byte
> array
> -----------------------------------------------------------------------------------
>
> Key: HADOOP-11323
> URL: https://issues.apache.org/jira/browse/HADOOP-11323
> Project: Hadoop Common
> Issue Type: Improvement
> Components: performance
> Affects Versions: 2.5.0
> Reporter: Wilfred Spiegelenburg
> Assignee: Wilfred Spiegelenburg
> Attachments: HADOOP-11323.patch
>
>
> When the default compare is used on a WritableComparator a reference to the
> second passed in byte array is kept in the buffer. Since WritableComparator
> keeps a reference to the buffer the byte will never be garbage collected.
> This can lead to a higher heap use than needed.
> The buffer should drop the reference to the byte array passed in. We can null
> out the byte array reference since the buffer is a private variable for the
> class.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
