[
https://issues.apache.org/jira/browse/HADOOP-10392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14075982#comment-14075982
]
Akira AJISAKA commented on HADOOP-10392:
----------------------------------------
{quote}
.../util/MRAsyncDiskService.java:
{code}
- return (new Path(path)).makeQualified(this.localFileSystem)
+ return this.localFileSystem.makeQualified(new Path(path))
.toUri().getPath();
{code}
{quote}
Since this is a test code, the path is supposed to belong to localFS. I prefer
to check if the path belongs to the FIleSystem in the test, and we should fix
the input path when the test fails.
bq. I'll fix them.
Looked around the patch, now I don't think the fix is needed. Please correct me
if I am wrong.
> Use FileSystem#makeQualified(Path) instead of Path#makeQualified(FileSystem)
> ----------------------------------------------------------------------------
>
> Key: HADOOP-10392
> URL: https://issues.apache.org/jira/browse/HADOOP-10392
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs
> Affects Versions: 2.3.0
> Reporter: Akira AJISAKA
> Assignee: Akira AJISAKA
> Priority: Minor
> Labels: newbie
> Attachments: HADOOP-10392.2.patch, HADOOP-10392.3.patch,
> HADOOP-10392.4.patch, HADOOP-10392.4.patch, HADOOP-10392.patch
>
>
> There're some methods calling Path.makeQualified(FileSystem), which causes
> javac warning.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
