[
https://issues.apache.org/jira/browse/HADOOP-10392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14075943#comment-14075943
]
Benjamin Zhitomirsky commented on HADOOP-10392:
-----------------------------------------------
Example of possible issue in your patch:
.../util/MRAsyncDiskService.java:
- return (new Path(path)).makeQualified(this.localFileSystem)
+ return this.localFileSystem.makeQualified(new Path(path))
.toUri().getPath();
The original would accept path which is already fully qualified and references
another file system. However your fix will cause the exception that I mentioned
above.
On the bright side all the fixes that you made in file systems and FileUtil
seems right.
> Use FileSystem#makeQualified(Path) instead of Path#makeQualified(FileSystem)
> ----------------------------------------------------------------------------
>
> Key: HADOOP-10392
> URL: https://issues.apache.org/jira/browse/HADOOP-10392
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs
> Affects Versions: 2.3.0
> Reporter: Akira AJISAKA
> Assignee: Akira AJISAKA
> Priority: Minor
> Labels: newbie
> Attachments: HADOOP-10392.2.patch, HADOOP-10392.3.patch,
> HADOOP-10392.4.patch, HADOOP-10392.4.patch, HADOOP-10392.patch
>
>
> There're some methods calling Path.makeQualified(FileSystem), which causes
> javac warning.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
