[
https://issues.apache.org/jira/browse/HADOOP-10720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14066990#comment-14066990
]
Alejandro Abdelnur commented on HADOOP-10720:
---------------------------------------------
almost there, a few minor nits, +1 after that:
*index.apt.vm*:
* The URL for decrypting has iv&material, it should not
*KeyProviderCryptoExtension.java*:
* {{warmUpEncryptedKeys()}} javadoc has param 'keVersions', method param name
is 'keyNames'
*KMS.java*:
* {{getKeyVersion()}} false change, don’t fix indentation in code not affected
by the patch
*KMSWebApps.java*:
* the {{getKeyProvider()}} should return a {{KeyProviderCryptoExtension}}
instance, then we don’t have to create a new extension on every request (KMS
instance is create per request per JAX-RPC spec)
*KMSClientProvider.java*:
* {{generateEncryptedKey()}} funny indentation on the last exception in the
method declaration
*KMSRESTConstants.java*:
* move {{IV_FIELD}} constant down with other {{_FIELD}} constants.
* {{ENCRYPTED_KEY_VERSION}} should be {{ENCRYPTED_KEY_VERSION_FIELD}}
> KMS: Implement generateEncryptedKey and decryptEncryptedKey in the REST API
> ---------------------------------------------------------------------------
>
> Key: HADOOP-10720
> URL: https://issues.apache.org/jira/browse/HADOOP-10720
> Project: Hadoop Common
> Issue Type: Improvement
> Components: security
> Affects Versions: 3.0.0
> Reporter: Alejandro Abdelnur
> Assignee: Arun Suresh
> Attachments: COMBO.patch, COMBO.patch, COMBO.patch, COMBO.patch,
> COMBO.patch, HADOOP-10720-10750.COMBO.patch, HADOOP-10720.1.patch,
> HADOOP-10720.10.patch, HADOOP-10720.11.patch, HADOOP-10720.12.patch,
> HADOOP-10720.13.patch, HADOOP-10720.2.patch, HADOOP-10720.3.patch,
> HADOOP-10720.4.patch, HADOOP-10720.5.patch, HADOOP-10720.6.patch,
> HADOOP-10720.7.patch, HADOOP-10720.8.patch, HADOOP-10720.9.patch,
> HADOOP-10720.patch, HADOOP-10720.patch, HADOOP-10720.patch,
> HADOOP-10720.patch, HADOOP-10720.patch
>
>
> KMS client/server should implement support for generating encrypted keys and
> decrypting them via the REST API being introduced by HADOOP-10719.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
