[
https://issues.apache.org/jira/browse/HADOOP-10720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14062890#comment-14062890
]
Alejandro Abdelnur commented on HADOOP-10720:
---------------------------------------------
A few final comments, then we are good:
*KMS.java*:
* {{encKeyVersionQueue}} is created with {{LOW_WATERMARK}} but comment states
that {{INIT_VALUE}} is used, it seems it should be {{INIT_VALUE}}
*ValueQueue.java*:
* there is a constructor that is not being used
* are we using all the defined policies?, it seems we are using
{{LOW_WATERMARK}} on the server side (when it should be {{INIT_VALUE}}, see
above), and on the client side it does not matter. If so, why not just handle
those 2 cases only.
* {{getAtMost()}} should use a switch/case instead if/else/… for the policy
> KMS: Implement generateEncryptedKey and decryptEncryptedKey in the REST API
> ---------------------------------------------------------------------------
>
> Key: HADOOP-10720
> URL: https://issues.apache.org/jira/browse/HADOOP-10720
> Project: Hadoop Common
> Issue Type: Improvement
> Components: security
> Affects Versions: 3.0.0
> Reporter: Alejandro Abdelnur
> Assignee: Arun Suresh
> Attachments: COMBO.patch, COMBO.patch, COMBO.patch, COMBO.patch,
> COMBO.patch, HADOOP-10720.1.patch, HADOOP-10720.2.patch,
> HADOOP-10720.3.patch, HADOOP-10720.4.patch, HADOOP-10720.5.patch,
> HADOOP-10720.6.patch, HADOOP-10720.7.patch, HADOOP-10720.8.patch,
> HADOOP-10720.9.patch, HADOOP-10720.patch, HADOOP-10720.patch,
> HADOOP-10720.patch, HADOOP-10720.patch, HADOOP-10720.patch
>
>
> KMS client/server should implement support for generating encrypted keys and
> decrypting them via the REST API being introduced by HADOOP-10719.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
