[
https://issues.apache.org/jira/browse/HADOOP-9163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13586435#comment-13586435
]
Suresh Srinivas commented on HADOOP-9163:
-----------------------------------------
Early comments:
# ProtobufRpcEngine.proto
#* RequestProto should be named RpcRequestHeaderProto and moved to
RpcHeader.proto? If so then ProtobufRpcEngine can be removed.
# ProtobufRpcEngine#constructRpcRequest() should be named
constuctRpcRequestHeader, if the above change is made. Also that method should
not throw ServiceException any more. The code can be more concise if you just
do {{return builder.build()}}, without declaring RequestProto.
# ProtobufEngine#invoke() - can you please move check for {{args}} length and
{{args[1] != null}} prior to calling {{constructRpcRequest()}}.
> The rpc msg in ProtobufRpcEngine.proto should be moved out to avoid an extra
> copy
> ----------------------------------------------------------------------------------
>
> Key: HADOOP-9163
> URL: https://issues.apache.org/jira/browse/HADOOP-9163
> Project: Hadoop Common
> Issue Type: Sub-task
> Reporter: Sanjay Radia
> Assignee: Sanjay Radia
> Attachments: Hadoop-9163-2.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
