[
https://issues.apache.org/jira/browse/HADOOP-8763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13455156#comment-13455156
]
Vinod Kumar Vavilapalli commented on HADOOP-8763:
-------------------------------------------------
We can just leave around the public constant Shell.SET_GROUP_COMMAND or
deprecate it. I am okay leaving it around.
Not sure of your usage of asserts vs exit-code, but in src/winutils/chown.c,
instead of asserts for zero-length string, we should log a msg to stderr and
return an EXIT_FAILURE? Also, if both are empty also you should return
EXIT_FAILURE?
bq. +On Linux, if a colon but no group name follows the user name, the group
of\n\
+the files is changed to that user\'s login group.
This code won't be invoked on linux, because, ahm, this is winutils? In any
case, that is not behaviour I know, a "chown user: filename" shouldn't change
the group-name
> Set group owner on Windows failed
> ---------------------------------
>
> Key: HADOOP-8763
> URL: https://issues.apache.org/jira/browse/HADOOP-8763
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Chuan Liu
> Assignee: Chuan Liu
> Priority: Minor
> Fix For: 1-win
>
> Attachments: HADOOP-8763-branch-1-win-2.patch,
> HADOOP-8763-branch-1-win.patch
>
>
> RawLocalFileSystem.setOwner() method may incorrectly set the group owner of a
> file on Windows.
> Specifically the following function in RawLocalFileSystem class will fail on
> Windows when username is null, i.e. only set group ownership.
> {code}
> public void setOwner(Path p, String username, String groupname)
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
