[ 
https://issues.apache.org/jira/browse/HADOOP-8763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13450259#comment-13450259
 ] 

Ivan Mitic commented on HADOOP-8763:
------------------------------------

Change looks great Chuan.

Two minor comments:
1. FileUtil#setOwner As this is a public api, it would be good to note that 
username and groupname cannot both be null.
2. FIleUtil.java:747 It seems that you moved a comment one line up.
                
> Set group owner on Windows failed
> ---------------------------------
>
>                 Key: HADOOP-8763
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8763
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Chuan Liu
>            Assignee: Chuan Liu
>            Priority: Minor
>             Fix For: 1-win
>
>         Attachments: HADOOP-8763-branch-1-win.patch
>
>
> RawLocalFileSystem.setOwner() method may incorrectly set the group owner of a 
> file on Windows.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to