[
https://issues.apache.org/jira/browse/HADOOP-19893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18087047#comment-18087047
]
ASF GitHub Bot commented on HADOOP-19893:
-----------------------------------------
ajfabbri commented on code in PR #8530:
URL: https://github.com/apache/hadoop/pull/8530#discussion_r3375575936
##########
.github/workflows/tmpl_cloud_aws.yml:
##########
@@ -87,6 +98,9 @@ jobs:
run: |
echo "Build image URL: ${{
needs.precondition.outputs.build_image_url }}"
- uses: actions/checkout@v6
+ with:
+ repository: ${{ inputs.checkout_repository || github.repository }}
+ ref: ${{ inputs.checkout_ref || github.ref }}
Review Comment:
The next step needs permissions to build and push a container image. Since
credentials are already deleted as part of the runner's post-job cleanup, why
would this change help anything?
> ci: s3a integration tests fail for fork PRs
> -------------------------------------------
>
> Key: HADOOP-19893
> URL: https://issues.apache.org/jira/browse/HADOOP-19893
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: ci, fs/s3
> Affects Versions: 3.5.0
> Reporter: Aaron Fabbri
> Assignee: Aaron Fabbri
> Priority: Major
> Labels: pull-request-available
>
> `.github/workflows/cloud_aws.yml` fails to execute when a PR branch is pushed
> to a fork repository. It works fine when pushing a branch to upstream
> (apache/hadoop). The problem is that the determination of the container image
> URL (which happens in `.github/actions/build_image_url/action.yml`) uses
> `apache` for `github.repository.owner` instead of `fork-owner`, due to use of
> `pull_request` trigger.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
