[
https://issues.apache.org/jira/browse/HADOOP-19893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18085909#comment-18085909
]
ASF GitHub Bot commented on HADOOP-19893:
-----------------------------------------
ajfabbri opened a new pull request, #8530:
URL: https://github.com/apache/hadoop/pull/8530
- **HADOOP-19893. Add manual cloud_aws CI trigger for fork PRs**
- **HADOOP-19893. Fix AWS test summary for manual runs.**
- **HADOOP-19893: Add sticky comment hint to S3A PRs from forks**
- **HADOOP-19893: add CLI hint for maintainers to manually trigger s3a CI**
- **HADOOP-19893: clarify status of manual trigger notification**
<!--
Thanks for sending a pull request!
1. If this is your first time, please read our contributor guidelines:
https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
2. Make sure your PR title starts with JIRA issue id, e.g.,
'HADOOP-17799. Your PR title ...'.
-->
### Description of PR
The approach we are following in HADOOP-19857–-running actions for
forked-repo
PRs on the forks–-doesn't work here, because fork repos don't have the
LOCALSTACK_CI_KEY secret installed. This PR:
- Adds a manually-triggered action that maintainers can use to run CI on
forked PRs.
- Includes a new `notify_cloud_aws.yml` workflow that leaves a sticky comment
on fork PRs that affect hadoop-aws (s3a) code, explaining how to manually
trigger
S3A tests.
### How was this patch tested?
I set up two fork repositories so I could test both the non-fork PR case,
and the fork PR case:
- Fork PR example:
[ajfabbri/hadoop/pull/13](https://github.com/ajfabbri/hadoop/pull/13)
- Non-fork PR example:
[ajfabbri/hadoop/pull/14](https://github.com/ajfabbri/hadoop/pull/14)
### For code changes:
- [x] Does the title or this PR starts with the corresponding JIRA issue id
(e.g. 'HADOOP-17799. Your PR title ...')?
- [na] Object storage: have the integration tests been executed and the
endpoint declared according to the connector-specific documentation?
- [na] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [na] If applicable, have you updated the `LICENSE`, `LICENSE-binary`,
`NOTICE-binary` files?
### AI Tooling
If an AI tool was used:
- [na] The PR includes the phrase "Contains content generated by <tool>"
where <tool> is the name of the AI tool used.
- [x] My use of AI contributions follows the ASF legal policy
https://www.apache.org/legal/generative-tooling.html
> ci: s3a integration tests fail for fork PRs
> -------------------------------------------
>
> Key: HADOOP-19893
> URL: https://issues.apache.org/jira/browse/HADOOP-19893
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: ci, fs/s3
> Affects Versions: 3.5.0
> Reporter: Aaron Fabbri
> Assignee: Aaron Fabbri
> Priority: Major
>
> `.github/workflows/cloud_aws.yml` fails to execute when a PR branch is pushed
> to a fork repository. It works fine when pushing a branch to upstream
> (apache/hadoop). The problem is that the determination of the container image
> URL (which happens in `.github/actions/build_image_url/action.yml`) uses
> `apache` for `github.repository.owner` instead of `fork-owner`, due to use of
> `pull_request` trigger.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
