pan3793 commented on PR #7892: URL: https://github.com/apache/hadoop/pull/7892#issuecomment-3273429535
> Do you think we should implement and use Thread Builder approach in this patch ? (see my reservations above) I think introducing Builder here is a kind of overdesign. @szetszwo do you have cases in your mind that can not be covered by @stoty's approach? If not, I strongly support @stoty's approach. > Is the way I split the patch acceptable (patches without JIRA id will be merged into the other ones) Thanks for splitting! I think HADOOP-19668 and HADOOP-19669 can be committed together; the current state is also fine. > What other changes (if any) do you think are necessary for patch to be accepted? I think it's already in good shape. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
