szetszwo commented on PR #7892: URL: https://github.com/apache/hadoop/pull/7892#issuecomment-3293346778
@stoty , @pan3793 , Honestly, I do prefer adding a builder instead of having multiple constructors with different parameter combinations. Also, a builder can build subclasses but constructors can't. In addition, extending the `Thread` class is not a good practice -- it is better to implement `Runnable`; see https://stackoverflow.com/questions/541487/implements-runnable-vs-extends-thread-in-java . We are a kind of making the ugly code worse. However, I won't -1 if we are not adding builder. It is just a suggestion for your consideration. I am fine if other people have agreed to do it differently. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
