[
https://issues.apache.org/jira/browse/HADOOP-19691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18020828#comment-18020828
]
ASF GitHub Bot commented on HADOOP-19691:
-----------------------------------------
slfan1989 commented on PR #7976:
URL: https://github.com/apache/hadoop/pull/7976#issuecomment-3300985791
> +1. Thanks @slfan1989 .
>
> I was going to suggest also banning `org.hamcrest`, but it looks like
there is still a tiny amount of hamcrest remaining in YARN. Maybe this is a
topic for a different PR.
>
> ```
> > grep -r --include '*.java' 'org.hamcrest' *
>
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-catalog/hadoop-yarn-applications-catalog-webapp/src/test/java/org/apache/hadoop/yarn/appcatalog/controller/AppListControllerTest.java:import
static org.hamcrest.MatcherAssert.assertThat;
>
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-catalog/hadoop-yarn-applications-catalog-webapp/src/test/java/org/apache/hadoop/yarn/appcatalog/controller/AppListControllerTest.java:import
static org.hamcrest.core.Is.is;
>
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-catalog/hadoop-yarn-applications-catalog-webapp/src/test/java/org/apache/hadoop/yarn/appcatalog/controller/AppDetailsControllerTest.java:import
static org.hamcrest.MatcherAssert.assertThat;
>
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-catalog/hadoop-yarn-applications-catalog-webapp/src/test/java/org/apache/hadoop/yarn/appcatalog/controller/AppDetailsControllerTest.java:import
static org.hamcrest.core.Is.is;
>
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-catalog/hadoop-yarn-applications-catalog-webapp/src/test/java/org/apache/hadoop/yarn/appcatalog/controller/AppStoreControllerTest.java:import
static org.hamcrest.MatcherAssert.assertThat;
>
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-catalog/hadoop-yarn-applications-catalog-webapp/src/test/java/org/apache/hadoop/yarn/appcatalog/controller/AppStoreControllerTest.java:import
static org.hamcrest.core.Is.is;
>
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/util/TestResourceCalculatorProcessTree.java:import
static org.hamcrest.MatcherAssert.assertThat;
>
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/util/TestResourceCalculatorProcessTree.java:import
static org.hamcrest.core.IsInstanceOf.instanceOf;
>
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/util/TestResourceCalculatorProcessTree.java:import
static org.hamcrest.core.IsSame.sameInstance;
> ```
@cnauroth Thank you for reviewing the code! I’ll submit a separate PR to
replace the usage of `org.hamcrest.`.
> [JDK17] Disallow JUnit4 Imports After JUnit5 Migration
> ------------------------------------------------------
>
> Key: HADOOP-19691
> URL: https://issues.apache.org/jira/browse/HADOOP-19691
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: build
> Affects Versions: 3.5.0
> Reporter: Shilun Fan
> Assignee: Shilun Fan
> Priority: Major
> Labels: pull-request-available
>
> As our project has fully migrated to JUnit5, we should now enforce a rule
> that prevents the import and usage of JUnit4 classes (such as org.junit.Test,
> org.junit.Assert, etc.) to ensure consistency, avoid regressions, and allow
> safe removal of legacy dependencies.
> This task involves identifying and eliminating any remaining JUnit4 imports,
> and introducing static code analysis or linting rules to ban future usage.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
