[
https://issues.apache.org/jira/browse/HADOOP-19691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18020636#comment-18020636
]
ASF GitHub Bot commented on HADOOP-19691:
-----------------------------------------
slfan1989 commented on PR #7976:
URL: https://github.com/apache/hadoop/pull/7976#issuecomment-3297850797
@TaoYang526 We are currently working on upgrading the project to JUnit 5,
and I have added a validation rule to prevent users from reintroducing JUnit 4
dependencies. During the review, I found that the testAsyncScheduleThreadExit
method used JUnit 4 features, so I made some modifications. Could you please
take a look and let me know if the changes are reasonable?
> [JDK17] Disallow JUnit4 Imports After JUnit5 Migration
> ------------------------------------------------------
>
> Key: HADOOP-19691
> URL: https://issues.apache.org/jira/browse/HADOOP-19691
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: build
> Affects Versions: 3.5.0
> Reporter: Shilun Fan
> Assignee: Shilun Fan
> Priority: Major
>
> As our project has fully migrated to JUnit5, we should now enforce a rule
> that prevents the import and usage of JUnit4 classes (such as org.junit.Test,
> org.junit.Assert, etc.) to ensure consistency, avoid regressions, and allow
> safe removal of legacy dependencies.
> This task involves identifying and eliminating any remaining JUnit4 imports,
> and introducing static code analysis or linting rules to ban future usage.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
