[
https://issues.apache.org/jira/browse/HADOOP-19609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18017430#comment-18017430
]
ASF GitHub Bot commented on HADOOP-19609:
-----------------------------------------
anmolanmol1234 commented on code in PR #7817:
URL: https://github.com/apache/hadoop/pull/7817#discussion_r2313784171
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsConnectionManager.java:
##########
@@ -290,35 +298,45 @@ private void logDebug(String message, Object... args) {
* @param route the HTTP route for which connections are created
* @param numberOfConnections the number of connections to create
*/
- private void cacheExtraConnection(final HttpRoute route, final int
numberOfConnections) {
- if (!isCaching.getAndSet(true)) {
- long start = System.currentTimeMillis();
- // Only one thread allowed at a time
- ExecutorService executorService =
Executors.newFixedThreadPool(Math.min(numberOfConnections, 5));
+ private void cacheExtraConnection(final HttpRoute route,
+ final int numberOfConnections) {
+ if (!isCacheRefreshInProgress.getAndSet(true)) {
+ long start = System.nanoTime();
+ CountDownLatch latch = new CountDownLatch(numberOfConnections);
for (int i = 0; i < numberOfConnections; i++) {
- executorService.submit(() -> {
+ kac.getFixedThreadPool().submit(() -> {
+ HttpClientConnection conn = null;
try {
- HttpClientConnection conn = httpConnectionFactory.create(route,
null);
- connect(conn, route, connectionTimeout, new
AbfsManagedHttpClientContext());
+ conn = httpConnectionFactory.create(route, null);
+ connect(conn, route, abfsConfiguration.getHttpConnectionTimeout(),
+ new AbfsManagedHttpClientContext());
addConnectionToCache(conn);
} catch (Exception e) {
- logDebug("Error creating connection: {}", e.getMessage());
+ logDebug("Error creating connection: {}", e.getMessage());
+ if (conn != null) {
Review Comment:
should be in finally block
> ABFS: Apache Client Connection Pool Relook
> ------------------------------------------
>
> Key: HADOOP-19609
> URL: https://issues.apache.org/jira/browse/HADOOP-19609
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/azure
> Affects Versions: 3.4.1
> Reporter: Manish Bhatt
> Assignee: Manish Bhatt
> Priority: Major
> Labels: pull-request-available
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
