[
https://issues.apache.org/jira/browse/HADOOP-19609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18017474#comment-18017474
]
ASF GitHub Bot commented on HADOOP-19609:
-----------------------------------------
anmolanmol1234 commented on code in PR #7817:
URL: https://github.com/apache/hadoop/pull/7817#discussion_r2314111794
##########
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/ITestAbfsClient.java:
##########
@@ -881,8 +880,10 @@ private void testIsNonEmptyDirectoryInternal(String
firstCT,
*/
@Test
public void testKeepAliveCacheInitializationWithApacheHttpClient() throws
Exception {
- Assume.assumeTrue(APACHE_HTTP_CLIENT == httpOperationType);
+ assumeThat(APACHE_HTTP_CLIENT).isEqualTo(httpOperationType);
final AzureBlobFileSystem fs = this.getFileSystem();
+ assumeThat(APACHE_HTTP_CLIENT).isEqualTo(
Review Comment:
Move assume statement above
##########
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/ITestAbfsClient.java:
##########
@@ -898,8 +899,11 @@ public void
testKeepAliveCacheInitializationWithApacheHttpClient() throws Except
*/
@Test
public void testStaleConnectionBehavior() throws Exception {
- Assume.assumeTrue(APACHE_HTTP_CLIENT == httpOperationType);
- Configuration conf = this.getFileSystem().getConf();
+ assumeThat(APACHE_HTTP_CLIENT).isEqualTo(httpOperationType);
+ final AzureBlobFileSystem fs = this.getFileSystem();
Review Comment:
same as above
> ABFS: Apache Client Connection Pool Relook
> ------------------------------------------
>
> Key: HADOOP-19609
> URL: https://issues.apache.org/jira/browse/HADOOP-19609
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/azure
> Affects Versions: 3.4.1
> Reporter: Manish Bhatt
> Assignee: Manish Bhatt
> Priority: Major
> Labels: pull-request-available
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
