[
https://issues.apache.org/jira/browse/HADOOP-19646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18012461#comment-18012461
]
ASF GitHub Bot commented on HADOOP-19646:
-----------------------------------------
slfan1989 commented on PR #7858:
URL: https://github.com/apache/hadoop/pull/7858#issuecomment-3162122354
> Can we move to AssertJ here?
>
> 1. it's a better syntax, and nicely extensible
> 2. it lets us cherrypick into java4 branches without any problems
> 3. everyone who has already used it knows the syntax
>
> I don't want to invest any time learning JUnit5's assert syntax, not given
AssertJ is good and I'm still learning the nuances in what is a very powerful
assertion language
Thank you very much for your feedback! I completely agree with your
suggestions. I will make improvements in this PR accordingly. Once the upgrade
to JUnit 5 is fully completed, I will create a separate JIRA ticket to
batch-convert JUnit 5 assertions to AssertJ.
> S3A: Migrate hadoop-aws module from JUnit4 Assume to JUnit5 Assumptions
> -----------------------------------------------------------------------
>
> Key: HADOOP-19646
> URL: https://issues.apache.org/jira/browse/HADOOP-19646
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: hadoop-aws
> Affects Versions: 3.5.0
> Reporter: Shilun Fan
> Assignee: Shilun Fan
> Priority: Major
> Labels: pull-request-available
>
> This task aims to migrate the test code in the {{hadoop-aws}} module from
> JUnit4's {{org.junit.Assume}} API to JUnit5's
> {{org.junit.jupiter.api.Assumptions}} API in order to unify the testing
> framework and improve maintainability.
> h4. Scope of changes:
> * Replace usages of {{{}Assume.assumeTrue(...){}}},
> {{{}Assume.assumeFalse(...){}}}, etc., with the corresponding methods from
> JUnit5, such as {{{}Assumptions.assumeTrue(...){}}};
> * Ensure the assertion logic remains consistent with the original behavior;
> * Update any outdated import statements referencing JUnit4's {{{}Assume{}}};
> * Verify that all affected unit tests pass correctly under JUnit5.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
