[
https://issues.apache.org/jira/browse/HADOOP-19646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18019599#comment-18019599
]
ASF GitHub Bot commented on HADOOP-19646:
-----------------------------------------
zhtttylz commented on code in PR #7951:
URL: https://github.com/apache/hadoop/pull/7951#discussion_r2340699995
##########
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/impl/ITestTreewalkProblems.java:
##########
@@ -316,7 +316,7 @@ public void testDistCp() throws Throwable {
options, getConfiguration());
} else {
// distcp fails if uploads are visible
- intercept(org.junit.ComparisonFailure.class, () -> {
+ intercept(org.opentest4j.AssertionFailedError.class, () -> {
Review Comment:
Thanks for the feedback—I’ll make the updates right away!
> S3A: Migrate hadoop-aws module from JUnit4 Assume to JUnit5 Assumptions
> -----------------------------------------------------------------------
>
> Key: HADOOP-19646
> URL: https://issues.apache.org/jira/browse/HADOOP-19646
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: hadoop-aws
> Affects Versions: 3.5.0
> Reporter: Shilun Fan
> Assignee: Shilun Fan
> Priority: Major
> Labels: pull-request-available
> Fix For: 3.5.0
>
>
> This task aims to migrate the test code in the {{hadoop-aws}} module from
> JUnit4's {{org.junit.Assume}} API to JUnit5's
> {{org.junit.jupiter.api.Assumptions}} API in order to unify the testing
> framework and improve maintainability.
> h4. Scope of changes:
> * Replace usages of {{{}Assume.assumeTrue(...){}}},
> {{{}Assume.assumeFalse(...){}}}, etc., with the corresponding methods from
> JUnit5, such as {{{}Assumptions.assumeTrue(...){}}};
> * Ensure the assertion logic remains consistent with the original behavior;
> * Update any outdated import statements referencing JUnit4's {{{}Assume{}}};
> * Verify that all affected unit tests pass correctly under JUnit5.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
