[
https://issues.apache.org/jira/browse/HADOOP-19604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18007780#comment-18007780
]
ASF GitHub Bot commented on HADOOP-19604:
-----------------------------------------
anmolanmol1234 commented on code in PR #7777:
URL: https://github.com/apache/hadoop/pull/7777#discussion_r2213043323
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AzureDFSIngressHandler.java:
##########
@@ -178,13 +179,24 @@ protected synchronized AbfsRestOperation
remoteFlush(final long offset,
tracingContextFlush.setIngressHandler(DFS_FLUSH);
tracingContextFlush.setPosition(String.valueOf(offset));
}
+ String fullBlobMd5 = computeFullBlobMd5();
LOG.trace("Flushing data at offset {} and path {}", offset,
getAbfsOutputStream().getPath());
- return getClient()
- .flush(getAbfsOutputStream().getPath(), offset, retainUncommitedData,
- isClose,
- getAbfsOutputStream().getCachedSasTokenString(), leaseId,
- getAbfsOutputStream().getContextEncryptionAdapter(),
- tracingContextFlush);
+ AbfsRestOperation op;
+ try {
+ op = getClient()
+ .flush(getAbfsOutputStream().getPath(), offset, retainUncommitedData,
+ isClose,
+ getAbfsOutputStream().getCachedSasTokenString(), leaseId,
+ getAbfsOutputStream().getContextEncryptionAdapter(),
+ tracingContextFlush, fullBlobMd5);
+ } catch (AbfsRestOperationException ex) {
+ LOG.error("Error in remote flush for path {} and offset {}",
+ getAbfsOutputStream().getPath(), offset, ex);
+ throw ex;
+ } finally {
+ getAbfsOutputStream().getFullBlobContentMd5().reset();
Review Comment:
done
> ABFS: Fix WASB ABFS compatibility issues
> ----------------------------------------
>
> Key: HADOOP-19604
> URL: https://issues.apache.org/jira/browse/HADOOP-19604
> Project: Hadoop Common
> Issue Type: Sub-task
> Affects Versions: 3.4.1
> Reporter: Anmol Asrani
> Assignee: Anmol Asrani
> Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.1
>
>
> Fix WASB ABFS compatibility issues. Fix issues such as:-
> # BlockId computation to be consistent across clients for PutBlock and
> PutBlockList
> # Restrict url encoding of certain json metadata during setXAttr calls.
> # Maintain the md5 hash of whole block to validate data integrity during
> flush.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
