[
https://issues.apache.org/jira/browse/HADOOP-19604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18005098#comment-18005098
]
ASF GitHub Bot commented on HADOOP-19604:
-----------------------------------------
manika137 commented on code in PR #7777:
URL: https://github.com/apache/hadoop/pull/7777#discussion_r2204544838
##########
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemAppend.java:
##########
@@ -1041,16 +1041,14 @@ public void testWriteAsyncOpFailedAfterCloseCalled()
throws Exception {
/**
* Helper method that generates blockId.
- * @param position The offset needed to generate blockId.
* @return String representing the block ID generated.
*/
- private String generateBlockId(AbfsOutputStream os, long position) {
+ private String generateBlockId(AbfsOutputStream os) {
String streamId = os.getStreamID();
- String streamIdHash = Integer.toString(streamId.hashCode());
- String blockId = String.format("%d_%s", position, streamIdHash);
- byte[] blockIdByteArray = new byte[BLOCK_ID_LENGTH];
- System.arraycopy(blockId.getBytes(), 0, blockIdByteArray, 0,
Math.min(BLOCK_ID_LENGTH, blockId.length()));
- return new String(Base64.encodeBase64(blockIdByteArray),
StandardCharsets.UTF_8);
+ UUID streamIdGuid =
UUID.nameUUIDFromBytes(streamId.getBytes(StandardCharsets.UTF_8));
+ long blockIndex = os.getBlockManager().getBlockCount();
+ String rawBlockId = String.format("%s-%06d", streamIdGuid, blockIndex);
Review Comment:
we can use the constant BLOCK_ID_FORMAT
> ABFS: Fix WASB ABFS compatibility issues
> ----------------------------------------
>
> Key: HADOOP-19604
> URL: https://issues.apache.org/jira/browse/HADOOP-19604
> Project: Hadoop Common
> Issue Type: Sub-task
> Affects Versions: 3.4.1
> Reporter: Anmol Asrani
> Assignee: Anmol Asrani
> Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.1
>
>
> Fix WASB ABFS compatibility issues. Fix issues such as:-
> # BlockId computation to be consistent across clients for PutBlock and
> PutBlockList
> # Restrict url encoding of certain json metadata during setXAttr calls.
> # Maintain the md5 hash of whole block to validate data integrity during
> flush.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
