[
https://issues.apache.org/jira/browse/HADOOP-19425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17925866#comment-17925866
]
ASF GitHub Bot commented on HADOOP-19425:
-----------------------------------------
anujmodi2021 commented on code in PR #7369:
URL: https://github.com/apache/hadoop/pull/7369#discussion_r1950323726
##########
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/ITestWasbUriAndConfiguration.java:
##########
@@ -659,7 +655,7 @@ public void testCanonicalServiceName() throws Exception {
conf.setBoolean(RETURN_URI_AS_CANONICAL_SERVICE_NAME_PROPERTY_NAME,
true);
FileSystem fs1 = FileSystem.newInstance(defaultUri, conf);
- Assert.assertEquals("getCanonicalServiceName() should return URI",
+ assertEquals("getCanonicalServiceName() should return URI",
Review Comment:
Need to fix the parameter order as per new format.
This will fix this failing test
##########
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/integration/ITestAzureHugeFiles.java:
##########
@@ -81,8 +81,8 @@ public class ITestAzureHugeFiles extends
AbstractAzureScaleTest {
private Path testPath;
@Override
Review Comment:
Do we need @BeforeEach here?
I think setup is not called before test method leading to failures
> [ABFS] Upgrade JUnit from 4 to 5 in hadoop-azure.
> -------------------------------------------------
>
> Key: HADOOP-19425
> URL: https://issues.apache.org/jira/browse/HADOOP-19425
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: build, fs/azure, test
> Affects Versions: 3.5.0
> Reporter: Shilun Fan
> Assignee: Shilun Fan
> Priority: Major
> Labels: pull-request-available
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
