[
https://issues.apache.org/jira/browse/HADOOP-19425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17925847#comment-17925847
]
ASF GitHub Bot commented on HADOOP-19425:
-----------------------------------------
anujmodi2021 commented on code in PR #7369:
URL: https://github.com/apache/hadoop/pull/7369#discussion_r1950200295
##########
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/ITestAzureFileSystemErrorConditions.java:
##########
@@ -157,7 +157,7 @@ public void testTransientErrorOnDelete() throws Exception {
// Need to do this test against a live storage account
AzureBlobStorageTestAccount testAccount =
AzureBlobStorageTestAccount.create();
- assumeNotNull(testAccount);
+ assumeTrue(testAccount != null);
Review Comment:
Nit: would it be better to define a accessible method
`assumeNotNull(variable)` that internally calls `assumeTrue(variable!= null);`
This will reduce the overall diffs I feel.
##########
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/ITestNativeAzureFileSystemConcurrencyLive.java:
##########
@@ -40,7 +41,7 @@ public class ITestNativeAzureFileSystemConcurrencyLive
extends AbstractWasbTestBase {
private static final int THREAD_COUNT = 102;
- private static final int TEST_EXECUTION_TIMEOUT = 30000;
+ private static final int TEST_EXECUTION_TIMEOUT = 30;
Review Comment:
Why we are reducing this value?? Any specific reason or observation around
this?
> [ABFS] Upgrade JUnit from 4 to 5 in hadoop-azure.
> -------------------------------------------------
>
> Key: HADOOP-19425
> URL: https://issues.apache.org/jira/browse/HADOOP-19425
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: build, fs/azure, test
> Affects Versions: 3.5.0
> Reporter: Shilun Fan
> Assignee: Shilun Fan
> Priority: Major
> Labels: pull-request-available
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
