brumi1024 commented on code in PR #5562:
URL: https://github.com/apache/hadoop/pull/5562#discussion_r1169804356
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java:
##########
@@ -137,6 +137,16 @@ private static void addDeprecatedKeys() {
// Resource types configs
////////////////////////////
+ public static final String NODE_STORE_ROOT_DIR_NUM_RETRIES =
+ YARN_PREFIX + "nodestore-rootdir.num-retries";
Review Comment:
Nit: Since this is an RM config (capacity scheduler feature) I think we
could use the yarn.resourcemanager prefix.
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java:
##########
@@ -137,6 +137,16 @@ private static void addDeprecatedKeys() {
// Resource types configs
////////////////////////////
+ public static final String NODE_STORE_ROOT_DIR_NUM_RETRIES =
+ YARN_PREFIX + "nodestore-rootdir.num-retries";
+
+ public static final int NODE_STORE_ROOT_DIR_NUM_DEFAULT_RETRIES = 3;
Review Comment:
Nit: To be inline with the other retries I think 500/1000 would be a more
appropriate default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
