brumi1024 commented on code in PR #5562:
URL: https://github.com/apache/hadoop/pull/5562#discussion_r1168885162
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/nodelabels/store/AbstractFSNodeStore.java:
##########
@@ -65,8 +65,30 @@ protected void initStore(Configuration conf, Path
fsStorePath,
this.fsWorkingPath = fsStorePath;
this.manager = mgr;
initFileSystem(conf);
- // mkdir of root dir path
- fs.mkdirs(fsWorkingPath);
+ // mkdir of root dir path with retry logic
+ int maxRetries = 3;
Review Comment:
Can you please create a configuration entry for the retry count and the
interval? Something like the
yarn.resourcemanager.zk-num-retries and
yarn.resourcemanager.zk-retry-interval-ms parameters defined for ZK
connections. That way the user could configure a longer period in case HDFS in
safe mode for a few minutes when the RM tries to start.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
