ahmarsuhail commented on code in PR #5421:
URL: https://github.com/apache/hadoop/pull/5421#discussion_r1144957314
##########
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/ITestS3ABucketExistence.java:
##########
@@ -124,30 +125,37 @@ private Configuration createConfigurationWithProbe(final
int probe) {
Configuration conf = new Configuration(getFileSystem().getConf());
S3ATestUtils.disableFilesystemCaching(conf);
conf.setInt(S3A_BUCKET_PROBE, probe);
+ conf.set(AWS_REGION, "eu-west-1");
Review Comment:
For this test, the region doesn't make a difference, as the bucket itself
doesn't exist and we always expect an UnknownStoreException to be thrown. We
just need to set any region here, to avoid the `getS3Region()` probe, otherwise
the getS3Region will throw the 404..and bucket probing will never happen. This
means it should be ok for third party stores too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
