ahmarsuhail commented on code in PR #5421:
URL: https://github.com/apache/hadoop/pull/5421#discussion_r1142323639
##########
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AUtils.java:
##########
@@ -807,10 +742,8 @@ private static AWSCredentialsProvider
createAWSV1CredentialProvider(
* @return the instantiated class
* @throws IOException on any instantiation failure.
*/
- private static AwsCredentialsProvider createAWSV2CredentialProvider(
- Configuration conf,
- Class<?> credClass,
- @Nullable URI uri) throws IOException {
+ private static AwsCredentialsProvider
createAWSV2CredentialProvider(Configuration conf,
Review Comment:
have moved all of this to new class `AwsCredentialListProvider`. not too
sure about the name, happy to change. Also was wondering if all the reflection
code (`getInstanceFromReflection()`) in S3AUtils should be moved out too, to
this `AwsCredentialListProvider` or maybe another new class in `s3a.auth` ?
Didn't move out currently as it's also used by the SignerFactory
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
