aparchoudhary commented on code in PR #5443:
URL: https://github.com/apache/hadoop/pull/5443#discussion_r1142075877
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/AbstractDelegationTokenSecretManager.java:
##########
@@ -434,16 +446,17 @@ private void updateCurrentKey() throws IOException {
DelegationKey newKey = new DelegationKey(newCurrentId, System
.currentTimeMillis()
+ keyUpdateInterval + tokenMaxLifetime, generateSecret());
- //Log must be invoked outside the lock on 'this'
- logUpdateMasterKey(newKey);
synchronized (this) {
+ storeDelegationKey(newKey);
Review Comment:
Won't updating currentKey need to be synchronized? Because if some other
thread is using this in createPassword() and in between lines
_identifier.setMasterKeyId(currentKey.getKeyId()) and
createPassword(identifier.getBytes(), currentKey.getKey())_; the currentKey
changes, won't that result in inconsistencies?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
